From 0185bc376e9a0e47c6d360b331be998ffef48680 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lucio=20Andr=C3=A9s=20Illanes=20Albornoz=20=28arab=2C=20vx?=
 =?UTF-8?q?p=29?= <lucio@lucioillanes.de>
Date: Sun, 3 Dec 2017 22:03:53 +0000
Subject: subr/*.subr: fix header legends. subr/ex_pkg_dispatch.subr: add
 warning to header concerning set -o errexit.

---
 subr/build_args.subr      | 4 ++++
 subr/build_checks.subr    | 4 ++++
 subr/ex_pkg_dispatch.subr | 6 +++++-
 subr/ex_rtl.subr          | 2 +-
 subr/ex_rtl_fetch.subr    | 2 +-
 subr/ex_rtl_fileop.subr   | 2 +-
 subr/ex_rtl_install.subr  | 2 +-
 subr/ex_rtl_log.subr      | 2 +-
 subr/ex_rtl_state.subr    | 2 +-
 9 files changed, 19 insertions(+), 7 deletions(-)

(limited to 'subr')

diff --git a/subr/build_args.subr b/subr/build_args.subr
index 38f10c50..2175665c 100644
--- a/subr/build_args.subr
+++ b/subr/build_args.subr
@@ -1,3 +1,7 @@
+#
+# set -o noglob is assumed.
+#
+
 BUILD_ARGS_SPEC="
 	ARG_IPV4_ONLY:-4
 	ARG_IPV6_ONLY:-6
diff --git a/subr/build_checks.subr b/subr/build_checks.subr
index 08abc684..055ed870 100644
--- a/subr/build_checks.subr
+++ b/subr/build_checks.subr
@@ -1,3 +1,7 @@
+#
+# set -o noglob is assumed.
+#
+
 build_checks() {
 	local __ _exit _pname;
 	for __ in ${DEFAULT_CHECK_PATH_VARS}; do
diff --git a/subr/ex_pkg_dispatch.subr b/subr/ex_pkg_dispatch.subr
index ad41616c..7a8a95d2 100644
--- a/subr/ex_pkg_dispatch.subr
+++ b/subr/ex_pkg_dispatch.subr
@@ -1,5 +1,9 @@
 #
-# set -o errexit -o noglob are assumed.
+# set -o noglob is assumed.
+# WARNING: ex_pkg_dispatch(), its caller, and its callers must _NOT_ be executed
+# as part of conditional evaluation, e.g. if, until, while, !, or && and ||, as
+# doing so would inhibit set -o errexit during execution of this function and its
+# subshell(!).  Instead, call ex_pkg_dispatch() and subsequently evaluate ${?}.
 #
 
 ex_pkg_dispatch() {
diff --git a/subr/ex_rtl.subr b/subr/ex_rtl.subr
index ecca3c80..d37e7083 100644
--- a/subr/ex_rtl.subr
+++ b/subr/ex_rtl.subr
@@ -1,5 +1,5 @@
 #
-# set -o errexit -o noglob are assumed.
+# set -o noglob is assumed.
 #
 
 EXP_RTL_IFS="${IFS}";
diff --git a/subr/ex_rtl_fetch.subr b/subr/ex_rtl_fetch.subr
index c5dfc559..5e76e42d 100644
--- a/subr/ex_rtl_fetch.subr
+++ b/subr/ex_rtl_fetch.subr
@@ -1,5 +1,5 @@
 #
-# set -o errexit -o noglob are assumed.
+# set -o noglob is assumed.
 #
 
 exp_rtl_fetch_url_git() {
diff --git a/subr/ex_rtl_fileop.subr b/subr/ex_rtl_fileop.subr
index 0666e7d0..62457835 100644
--- a/subr/ex_rtl_fileop.subr
+++ b/subr/ex_rtl_fileop.subr
@@ -1,5 +1,5 @@
 #
-# set -o errexit -o noglob are assumed.
+# set -o noglob is assumed.
 #
 
 exp_rtl_fileop_check() {
diff --git a/subr/ex_rtl_install.subr b/subr/ex_rtl_install.subr
index 5dc2a088..19504a85 100644
--- a/subr/ex_rtl_install.subr
+++ b/subr/ex_rtl_install.subr
@@ -1,5 +1,5 @@
 #
-# set -o errexit -o noglob are assumed.
+# set -o noglob is assumed.
 #
 
 ex_rtl_install() {
diff --git a/subr/ex_rtl_log.subr b/subr/ex_rtl_log.subr
index 71e52fa2..43e22ec8 100644
--- a/subr/ex_rtl_log.subr
+++ b/subr/ex_rtl_log.subr
@@ -1,5 +1,5 @@
 #
-# set -o errexit -o noglob are assumed.
+# set -o noglob is assumed.
 #
 
 ex_rtl_log_env_vars() {
diff --git a/subr/ex_rtl_state.subr b/subr/ex_rtl_state.subr
index fa07ff35..1cdd42aa 100644
--- a/subr/ex_rtl_state.subr
+++ b/subr/ex_rtl_state.subr
@@ -1,5 +1,5 @@
 #
-# set -o errexit -o noglob are assumed.
+# set -o noglob is assumed.
 #
 
 ex_rtl_state_set() {
-- 
cgit v1.2.3