build.sh, {subr,vars}/*: general cleanup.

1 files changed, 88 insertions, 84 deletions

diff --git a/vars/gcc.vars b/vars/gcc.vars
index 69d02b28..b1f6abab 100644
--- a/vars/gcc.vars
+++ b/vars/gcc.vars
@@ -7,25 +7,25 @@
 pkgp_gcc_setup_env() {
 	local __;
 	export MAKE="make LIBTOOL=slibtool";
-	export	cbb_ldflags_for_target=--sysroot=${PKG_PREFIX}	\
-		cbb_sysroot_for_libgcc=${PKG_PREFIX}		\
-		cbb_target=${PKG_TARGET};
-	case ${PKG_NAME} in
+	export	cbb_ldflags_for_target=--sysroot="${PKG_PREFIX}"	\
+		cbb_sysroot_for_libgcc="${PKG_PREFIX}"			\
+		cbb_target="${PKG_TARGET}";
+	case "${PKG_NAME}" in
 	gcc_stage1)
 		export	cbb_neutral_libiberty=no		\
-			cbb_xgcc_for_specs=${WORKDIR}/${PKG_BUILD_DIR}/gcc/xgcc; ;;
+			cbb_xgcc_for_specs="${WORKDIR}/${PKG_BUILD_DIR}/gcc/xgcc"; ;;
 	gcc_stage1_cross_x86_64_w64_mingw32)
 		export	cbb_neutral_libiberty=no		\
-			cbb_xgcc_for_specs=${WORKDIR}/${PKG_BUILD_DIR}/gcc/xgcc; ;;
+			cbb_xgcc_for_specs="${WORKDIR}/${PKG_BUILD_DIR}/gcc/xgcc"; ;;
 	gcc_stage1_native_x86_64_w64_mingw32)
 		export	cbb_neutral_libiberty=no		\
-			cbb_xgcc_for_specs=${PKG_TARGET}-gcc; ;;
+			cbb_xgcc_for_specs="${PKG_TARGET}-gcc"; ;;
 	gcc_native)
-		export	cbb_xgcc_for_specs=${PKG_TARGET}-gcc	\
-			sysroot_headers_suffix=${PKG_PREFIX}; ;;
+		export	cbb_xgcc_for_specs="${PKG_TARGET}-gcc"	\
+			sysroot_headers_suffix="${PKG_PREFIX}"; ;;
 	esac;
 	GCCTARGET_FLAGS="-DIN_TARGET_LIBRARY_BUILD --sysroot=${PKG_PREFIX}";
-	GCCFLAGS="${CFLAGS:+${CFLAGS} }--include $(readlink -f ${WORKDIR}/cbb-gcc-${1}/libc/cbb-musl-pe.h)";
+	GCCFLAGS="${CFLAGS:+${CFLAGS} }--include $(readlink -f "${WORKDIR}/cbb-gcc-${1}/libc/cbb-musl-pe.h")";
 	for __ in CFLAGS CFLAGS_FOR_BUILD CPPFLAGS_FOR_BUILD CXXFLAGS CXXFLAGS_FOR_BUILD; do
 		export "${__}=${GCCFLAGS}";
 	done;
@@ -39,10 +39,10 @@ pkgp_gcc_setup_env() {
 };
 
 pkgp_gcc_configure() {
-	build_fileop rm ${PKG_BUILD_DIR};
-	build_fileop mkdir ${PKG_BUILD_DIR};
-	build_fileop cd ${PKG_BUILD_DIR};
-	../cbb-gcc-${PKG_GCC_VERSION}/configure "${@}"	\
+	build_fileop rm "${PKG_BUILD_DIR}";
+	build_fileop mkdir "${PKG_BUILD_DIR}";
+	build_fileop cd "${PKG_BUILD_DIR}";
+	"../cbb-gcc-${PKG_GCC_VERSION}/configure" "${@}"\
 		--disable-bootstrap			\
 		--disable-libmudflap			\
 		--disable-multilib			\
@@ -62,9 +62,9 @@ pkgp_gcc_configure() {
 		--enable-secureplt			\
 		--enable-shared				\
 		--enable-threads=posix			\
-		--target=${PKG_TARGET}			\
+		--target="${PKG_TARGET}"		\
 		--with-fpmath=sse;
-	set_build_script_done ${PKG_NAME} configure -build;
+	set_build_script_done "${PKG_NAME}" configure -build;
 };
 
 pkg_gcc_stage1_cross_x86_64_w64_mingw32_all() {
@@ -76,169 +76,173 @@ pkg_gcc_stage1_native_x86_64_w64_mingw32_all() {
 };
 
 pkg_gcc_stage1_all() {
-	local __;
-	case ${PKG_NAME} in
+	local __ _restart_at="${1}";
+	case "${PKG_NAME}" in
 	gcc_stage1)
 		PKG_GCC_VERSION="${PKG_GCC_STAGE1_VERSION}";
-		set_build_dir cbb-gcc-${PKG_GCC_VERSION} cross;
+		set_build_dir "cbb-gcc-${PKG_GCC_VERSION}" cross;
 		;;
 	gcc_stage1_cross_x86_64_w64_mingw32)
 		PKG_GCC_VERSION="${PKG_GCC_STAGE1_CROSS_X86_64_W64_MINGW32_VERSION}";
-		set_build_dir cbb-gcc-${PKG_GCC_VERSION} cross;
+		set_build_dir "cbb-gcc-${PKG_GCC_VERSION}" cross;
 		;;
 	gcc_stage1_native_x86_64_w64_mingw32)
 		PKG_GCC_VERSION="${PKG_GCC_STAGE1_NATIVE_X86_64_W64_MINGW32_VERSION}";
-		set_build_dir cbb-gcc-${PKG_GCC_VERSION} native;
+		set_build_dir "cbb-gcc-${PKG_GCC_VERSION}" native;
 		;;
 	esac;
 	# GCC, stage1.
-	if ! is_build_script_done ${PKG_NAME} fetch; then
+	if ! is_build_script_done "${PKG_NAME}" fetch "${_restart_at}"; then
 		pkg_fetch -git "cbb-gcc-${PKG_GCC_VERSION}=${GITROOT}/cbb/cbb-gcc-${PKG_GCC_VERSION}";
-		set_build_script_done ${PKG_NAME} fetch -configure;
+		set_build_script_done "${PKG_NAME}" fetch -configure;
 	fi;
-	pkgp_gcc_setup_env ${PKG_GCC_VERSION};
-	if ! is_build_script_done ${PKG_NAME} configure; then
-		build_fileop mkdir ${PKG_PREFIX}/include;
-		[ \! -d ${PKG_PREFIX}/usr ] &&			\
-			build_fileop ln_symbolic . ${PKG_PREFIX}/usr;
-		case ${PKG_NAME} in
+	pkgp_gcc_setup_env "${PKG_GCC_VERSION}";
+	if ! is_build_script_done "${PKG_NAME}" configure "${_restart_at}"; then
+		build_fileop mkdir "${PKG_PREFIX}/include";
+		[ \! -d "${PKG_PREFIX}/usr" ] &&			\
+			build_fileop ln_symbolic . "${PKG_PREFIX}/usr";
+		case "${PKG_NAME}" in
 		gcc_stage1)
 			pkgp_gcc_configure				\
 				--disable-sjlj-exceptions		\
-				--prefix=${PREFIX}			\
-				--with-sysroot=${PREFIX}/${PKG_TARGET}; ;;
+				--prefix="${PREFIX}"			\
+				--with-sysroot="${PREFIX}/${PKG_TARGET}"; ;;
 		gcc_stage1_cross_x86_64_w64_mingw32)
 			pkgp_gcc_configure				\
 				--enable-sjlj-exceptions		\
-				--prefix=${PREFIX}			\
-				--with-sysroot=${PREFIX}/${PKG_TARGET}	\
+				--prefix="${PREFIX}"			\
+				--with-sysroot="${PREFIX}/${PKG_TARGET}"\
 				--without-headers; ;;
 		gcc_stage1_native_x86_64_w64_mingw32)
-			patch -b -d cbb-gcc-4.6.4 -p1 < ${MIDIPIX_BUILD_PWD}/patches/${PKG_NAME}.local.patch;
+			patch -b -d cbb-gcc-4.6.4 -p1 < "${MIDIPIX_BUILD_PWD}/patches/${PKG_NAME}.local.patch";
 			pkgp_gcc_configure				\
 				--build=x86_64-unknown-linux-gnu	\
 				--enable-sjlj-exceptions		\
 				--host=x86_64-nt64-midipix		\
 				--prefix=/				\
-				--with-elf=${PKG_PREFIX}		\
-				--with-gmp=${PKG_PREFIX}		\
-				--with-mpc=${PKG_PREFIX}		\
-				--with-mpfr=${PKG_PREFIX}		\
+				--with-elf="${PKG_PREFIX}"		\
+				--with-gmp="${PKG_PREFIX}"		\
+				--with-mpc="${PKG_PREFIX}"		\
+				--with-mpfr="${PKG_PREFIX}"		\
 				--with-sysroot=				\
 				--without-headers; ;;
 		esac;
 	else
-		build_fileop cd ${PKG_BUILD_DIR};
+		build_fileop cd "${PKG_BUILD_DIR}";
 	fi;
-	if ! is_build_script_done ${PKG_NAME} build; then
+	if ! is_build_script_done "${PKG_NAME}" build "${_restart_at}"; then
 		make ${MAKEFLAGS} all-gcc;
-		set_build_script_done ${PKG_NAME} build -install;
+		set_build_script_done "${PKG_NAME}" build -install;
 	fi;
-	if ! is_build_script_done ${PKG_NAME} install; then
-		case ${PKG_NAME} in
+	if ! is_build_script_done "${PKG_NAME}" install "${_restart_at}"; then
+		case "${PKG_NAME}" in
 		gcc_stage1)
 			make ${MAKEFLAGS} install-gcc; ;;
 		gcc_stage1_cross_x86_64_w64_mingw32)
 			make ${MAKEFLAGS} install-gcc; ;;
 		gcc_stage1_native_x86_64_w64_mingw32)
-			make ${MAKEFLAGS} DESTDIR=${PKG_PREFIX} install-gcc; ;;
+			make ${MAKEFLAGS} "DESTDIR=${PKG_PREFIX}" install-gcc; ;;
 		esac;
 		__="$(uname -s)";
 		if [ "${__#*CYGWIN*}" != "${__}" ]; then
-			build_fileop ln_symbolic ${PREFIX}/libexec/gcc/${PKG_TARGET}/${PKG_GCC_VERSION}/liblto_plugin.dll.a	\
-				build_fileop ln_symbolic ${PREFIX}/libexec/gcc/${PKG_TARGET}/${PKG_GCC_VERSION}/liblto_plugin.so;
+			build_fileop ln_symbolic "${PREFIX}/libexec/gcc/${PKG_TARGET}/${PKG_GCC_VERSION}/liblto_plugin.dll.a"	\
+				build_fileop ln_symbolic "${PREFIX}/libexec/gcc/${PKG_TARGET}/${PKG_GCC_VERSION}/liblto_plugin.so";
 		fi;
-		set_build_script_done ${PKG_NAME} install finish;
+		set_build_script_done "${PKG_NAME}" install finish;
 	fi;
 	exit 0;
 };
 
 pkg_gcc_runtime_all() {
+	local _restart_at="${1}";
 	export MAKE="make LIBTOOL=slibtool";
-	set_build_dir cbb-gcc-${PKG_GCC_RUNTIME_VERSION} cross;
-	build_fileop cd ${PKG_BUILD_DIR};
+	set_build_dir "cbb-gcc-${PKG_GCC_RUNTIME_VERSION}" cross;
+	build_fileop cd "${PKG_BUILD_DIR}";
 	# GCC, compiler runtime.
-	if ! is_build_script_done ${PKG_NAME} build; then
+	if ! is_build_script_done "${PKG_NAME}" build "${_restart_at}"; then
 		make ${MAKEFLAGS} all-target-libgcc;
-		set_build_script_done ${PKG_NAME} build -install;
+		set_build_script_done "${PKG_NAME}" build -install;
 	fi;
-	if ! is_build_script_done ${PKG_NAME} install; then
+	if ! is_build_script_done "${PKG_NAME}" install "${_restart_at}"; then
 		make ${MAKEFLAGS} install-target-libgcc;
-		set_build_script_done ${PKG_NAME} install finish;
+		set_build_script_done "${PKG_NAME}" install finish;
 	fi;
 	exit 0;
 };
 
 pkg_gcc_libstdcpp_v3_all() {
+	local _restart_at="${1}";
 	export MAKE="make LIBTOOL=slibtool";
-	set_build_dir cbb-gcc-${PKG_GCC_LIBSTDCPP_V3_VERSION} cross;
-	build_fileop cd ${PKG_BUILD_DIR};
+	set_build_dir "cbb-gcc-${PKG_GCC_LIBSTDCPP_V3_VERSION}" cross;
+	build_fileop cd "${PKG_BUILD_DIR}";
 	# GCC, libstdc++-v3.
-	if ! is_build_script_done ${PKG_NAME} build; then
+	if ! is_build_script_done "${PKG_NAME}" build "${_restart_at}"; then
 		make ${MAKEFLAGS} all-target-libstdc++-v3;
-		set_build_script_done ${PKG_NAME} build -install;
+		set_build_script_done "${PKG_NAME}" build -install;
 	fi;
-	if ! is_build_script_done ${PKG_NAME} install; then
+	if ! is_build_script_done "${PKG_NAME}" install "${_restart_at}"; then
 		make ${MAKEFLAGS} install-target-libstdc++-v3;
-		set_build_script_done ${PKG_NAME} install finish;
+		set_build_script_done "${PKG_NAME}" install finish;
 	fi;
 	exit 0;
 };
 
 pkg_gcc_full_all() {
+	local _restart_at="${1}";
 	export MAKE="make LIBTOOL=slibtool";
-	set_build_dir cbb-gcc-${PKG_GCC_FULL_VERSION} cross;
-	build_fileop cd ${PKG_BUILD_DIR};
+	set_build_dir "cbb-gcc-${PKG_GCC_FULL_VERSION}" cross;
+	build_fileop cd "${PKG_BUILD_DIR}";
 	# GCC, everything else.
-	if ! is_build_script_done ${PKG_NAME} build; then
+	if ! is_build_script_done "${PKG_NAME}" build "${_restart_at}"; then
 		make ${MAKEFLAGS};
-		set_build_script_done ${PKG_NAME} build -install;
+		set_build_script_done "${PKG_NAME}" build -install;
 	fi;
-	if ! is_build_script_done ${PKG_NAME} install; then
+	if ! is_build_script_done "${PKG_NAME}" install "${_restart_at}"; then
 		make ${MAKEFLAGS} install;
-		set_build_script_done ${PKG_NAME} install finish;
+		set_build_script_done "${PKG_NAME}" install finish;
 	fi;
 	exit 0;
 };
 
 pkg_gcc_native_all() {
+	local _restart_at="${1}" _configure_host;
 	PKG_GCC_VERSION="${PKG_GCC_NATIVE_VERSION}";
 	export MAKE="make LIBTOOL=slibtool";
 	# GCC, native.
-	set_build_dir cbb-gcc-${PKG_GCC_VERSION} native;
-	pkgp_gcc_setup_env ${PKG_GCC_VERSION};
-	if ! is_build_script_done ${PKG_NAME} configure; then
-		build_fileop mkdir ${PKG_PREFIX}/${PKG_TARGET};
-		if [ \! -d ${PKG_PREFIX}/${PKG_TARGET}/usr ]; then
-			build_fileop ln_symbolic . ${PKG_PREFIX}/${PKG_TARGET}/usr;
+	set_build_dir "cbb-gcc-${PKG_GCC_VERSION}" native;
+	pkgp_gcc_setup_env "${PKG_GCC_VERSION}";
+	if ! is_build_script_done "${PKG_NAME}" configure "${_restart_at}"; then
+		build_fileop mkdir "${PKG_PREFIX}/${PKG_TARGET}";
+		if [ \! -d "${PKG_PREFIX}/${PKG_TARGET}/usr" ]; then
+			build_fileop ln_symbolic . "${PKG_PREFIX}/${PKG_TARGET}/usr";
 		fi;
 		if [ "${ARCH}" = nt32 ]; then
-			_pgna_host="i686-nt32-midipix";
+			_configure_host="i686-nt32-midipix";
 		else
-			_pgna_host="x86_64-nt64-midipix";
+			_configure_host="x86_64-nt64-midipix";
 		fi;
 		pkgp_gcc_configure				\
 			--disable-sjlj-exceptions		\
-			--host=${_pgna_host}			\
+			--host="${_configure_host}"		\
 			--prefix=/				\
-			--with-elf=${PKG_PREFIX}		\
-			--with-gmp=${PKG_PREFIX}		\
-			--with-mpc=${PKG_PREFIX}		\
-			--with-mpfr=${PKG_PREFIX}		\
+			--with-elf="${PKG_PREFIX}"		\
+			--with-gmp="${PKG_PREFIX}"		\
+			--with-mpc="${PKG_PREFIX}"		\
+			--with-mpfr="${PKG_PREFIX}"		\
 			--with-sysroot=;
 	else
-		build_fileop cd ${PKG_BUILD_DIR};
+		build_fileop cd "${PKG_BUILD_DIR}";
 	fi;
-	if ! is_build_script_done ${PKG_NAME} build; then
+	if ! is_build_script_done "${PKG_NAME}" build "${_restart_at}"; then
 		make ${MAKEFLAGS} all-gcc;
 		make ${MAKEFLAGS} all-target-libgcc;
 		make ${MAKEFLAGS} all-target-libstdc++-v3;
 		make ${MAKEFLAGS} all;
-		set_build_script_done ${PKG_NAME} build -install;
+		set_build_script_done "${PKG_NAME}" build -install;
 	fi;
-	if ! is_build_script_done ${PKG_NAME} install; then
-		make ${MAKEFLAGS} DESTDIR=${PKG_PREFIX} install;
-		set_build_script_done ${PKG_NAME} install finish;
+	if ! is_build_script_done "${PKG_NAME}" install "${_restart_at}"; then
+		make ${MAKEFLAGS} "DESTDIR=${PKG_PREFIX}" install;
+		set_build_script_done "${PKG_NAME}" install finish;
 	fi;
 	exit 0;
 };